Fix terminal total difficulty gauge overflow - #93
Open
damilolaedwards wants to merge 1 commit into
Open
Conversation
The gauge converted TerminalTotalDifficulty with big.Int.Uint64, which the standard library documents as undefined when the value doesn't fit in 64 bits. Mainnet's TTD doesn't fit, so the exported metric silently reported a meaningless number. It now goes through big.Float first, the same way the adjacent trillions gauge already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gauge converted TerminalTotalDifficulty with big.Int.Uint64, which the standard library documents as undefined when the value doesn't fit in 64 bits. Mainnet's TTD doesn't fit, so the exported beacon_spec_terminal_total_difficulty metric silently reported a meaningless number on mainnet.
Fix goes through big.Float first, the same way the adjacent trillions gauge already does (that gauge only exists because someone hit this same overflow and worked around it there without fixing the raw one).
Test plan